Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix c compiler setup #562

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

dstansby
Copy link
Contributor

This is the change needed to fix the conda-forge build for numcodecs 0.13.0. Calling customize_compiler correctly sets up the Python paths on the compiler.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (8b53fc1) to head (69b6acc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2339     2339           
=======================================
  Hits         2337     2337           
  Misses          2        2           

@jakirkham jakirkham merged commit 79d1a8d into zarr-developers:main Aug 19, 2024
26 checks passed
@jakirkham
Copy link
Member

Thanks David! 🙏

@dstansby dstansby deleted the fix-compiler branch August 20, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants