Skip to content

Commit

Permalink
Drop unused Python 3.7 compatibility code (#406)
Browse files Browse the repository at this point in the history
Now that Python 3.8 is the minimum supported version, there is no need
for this `typing_extensions` branch or a dependency on
`typing-extensions`. So drop both to cleanup the code. Also should bring
coverage back up.
  • Loading branch information
jakirkham authored Dec 14, 2022
1 parent 4a029c9 commit f9f4cd3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docs/release.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Maintenance
By :user:`Dimitri Papadopoulos Orfanos <DimitriPapadopoulos>`, :issue:`369`.

* Drop Python 3.7.
By :user:`John Kirkham <jakirkham>`, :issue:`405`.
By :user:`John Kirkham <jakirkham>`,, :issue:`405` :issue:`406`.

* Test with zfpy 1.0.0.
By :user:`John Kirkham <jakirkham>`, :issue:`385`.
Expand Down
8 changes: 1 addition & 7 deletions numcodecs/ndarray_like.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
import sys
from typing import Any, Dict, Optional, Tuple, Type

if sys.version_info >= (3, 8):
from typing import Protocol, runtime_checkable
else:
from typing_extensions import Protocol, runtime_checkable
from typing import Any, Dict, Optional, Protocol, Tuple, Type, runtime_checkable


class _CachedProtocolMeta(Protocol.__class__):
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ readme = "README.rst"
dependencies = [
"entrypoints",
"numpy>=1.7",
"typing-extensions>=3.7.4"
]
requires-python = ">=3.8"
dynamic = [
Expand Down

0 comments on commit f9f4cd3

Please sign in to comment.