Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypothesis test broadcasting #139

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Hypothesis test broadcasting #139

merged 4 commits into from
Jun 17, 2024

Conversation

TomNicholas
Copy link
Member

This definitely found a few bugs, but I'm not sure there's any point fixing them in main when I'm about to change the entire implementation in #107 anyway...

  • Works towards Hypothesis testing #9 for array functions on the ManifestArray class
  • Tests added
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst

@TomNicholas TomNicholas mentioned this pull request Jun 12, 2024
Merged
@TomNicholas TomNicholas merged commit e72fd93 into main Jun 17, 2024
4 of 7 checks passed
@TomNicholas TomNicholas mentioned this pull request Jun 17, 2024
Merged
4 tasks
@TomNicholas TomNicholas deleted the hypothesis_test_broadcasting branch June 18, 2024 04:54
@TomNicholas
Copy link
Member Author

I basically reverted this in #107 (specifically dc824bb) because I realised I misunderstood what hypothesis.extra.numpy.broadcastable_shapes does, and so this test was generating invalid arguments to broadcast_to.

The updated test did still reveal a real bug though, which is tracked in #146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomNicholas