Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup Makefile help and Speedup builds #847

Merged
merged 9 commits into from
Oct 7, 2022
Merged

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 5, 2022

Description

This adds more help information to our Makefile and doesn't rebuild the UI unless explicitly asked for. Mostly a suggested improvement

Related Issue

Fixes # N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea--but I think we need to tweak the git diff a bit, in testing this way won't capture staged files that are changed and I'd rather err on the side of rebuild vs not.

Current method:

Screen Shot 2022-10-06 at 9 39 18 PM

Using --staged/--cached (only gets staged):

Screen Shot 2022-10-06 at 9 41 34 PM

Using git diff HEAD gets both staged & un-staged changes:

Screen Shot 2022-10-06 at 9 42 48 PM

@Racer159
Copy link
Contributor Author

Racer159 commented Oct 7, 2022

I love this idea--but I think we need to tweak the git diff a bit, in testing this way won't capture staged files that are changed and I'd rather err on the side of rebuild vs not.

Current method:

Screen Shot 2022-10-06 at 9 39 18 PM ### Using `--staged/--cached` (only gets staged): Screen Shot 2022-10-06 at 9 41 34 PM ### Using `git diff HEAD` gets both staged & un-staged changes: Screen Shot 2022-10-06 at 9 42 48 PM

Good catch! Changed to git diff HEAD

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this feature!

@jeff-mccoy jeff-mccoy merged commit 96d8a81 into master Oct 7, 2022
@bdfinst bdfinst deleted the cleanup-makefile branch January 12, 2023 22:33
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Adds more help information to our Makefile and doesn't rebuild the UI unless explicitly asked for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants