Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsxImproveElementsSuggestions stops code completions #205

Closed
regalstreak opened this issue Apr 20, 2024 · 1 comment
Closed

jsxImproveElementsSuggestions stops code completions #205

regalstreak opened this issue Apr 20, 2024 · 1 comment
Assignees

Comments

@regalstreak
Copy link

"tsEssentialPlugins.jsxImproveElementsSuggestions.enabled": true, // default behaviour

image

"tsEssentialPlugins.jsxImproveElementsSuggestions.enabled": false,

image

Whole component:

"use client";
import { LinkIcon } from "lucide-react";
import Image from "next/image";

const getFavicon = (url: string) => {
	return `https://s2.googleusercontent.com/s2/favicons?domain_url=${url}&sz=64`;
};

export const Favicon = ({ item }: { item: string }) => {
	if (item === "direct" || item === "null" || !item) {
		return <LinkIcon size={16} />;
	}
	return (
		<div>
			<Image
				src={getFavicon(item)}
				width={16}
				height={16}
				alt={"favicon"}
					
			/>
		</div>
	);
};

zardoy added a commit that referenced this issue Apr 21, 2024
fixes jsxImproveElementsSuggestions stops code completions #205
@zardoy
Copy link
Owner

zardoy commented Apr 21, 2024

its probably experiments.excludeNonJsxCompletions was causing it, not tsEssentialPlugins.jsxImproveElementsSuggestions.enabled. Anyway, thank you so much for the report. Will be released tomorrow.

@zardoy zardoy closed this as completed Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants