client: fix concurrency issue in test #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop the spider only after the access to the seed URL occurred and verify that the new URL was not accessed, otherwise the test could fail because the seed URL could be accessed between the calls to start and stop. Signed-off-by: thc202 <thc202@gmail.com>
psiinon
approved these changes
Dec 18, 2024
|
Ha - my PR had another fix for this issue, but I think this one is better 😁 |
kingthorin
approved these changes
Dec 18, 2024
|
No New Or Fixed Issues Found |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop the spider only after the access to the seed URL occurred and verify that the new URL was not accessed, otherwise the test could fail because the seed URL could be accessed between the calls to start and stop.