Client: code refactor #6004
Merged
Client: code refactor #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
client/refactor
branch
from
0fdd54c to
276bad4
Compare
|
No New Or Fixed Issues Found |
psiinon
force-pushed
the
client/refactor
branch
from
276bad4 to
0b4eec5
Compare
kingthorin
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Is it "weird" kinda java standards wise to have "Abstract' in the middle?
Also for a lot of these class names do they really need "Client" since it's obviously the client add-on/package.
There was a problem hiding this comment.
I think this PR should just move classes / change visibility. Happy for future PRs to rename things...
There was a problem hiding this comment.
Okay, neither are blockers.
psiinon
force-pushed
the
client/refactor
branch
from
0b4eec5 to
f7a20a8
Compare
|
Ready for review. |
thc202
reviewed
Dec 12, 2024
addOns/client/src/main/java/org/zaproxy/addon/client/ExtensionClientIntegration.java
Outdated
Show resolved
Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/internal/ClientSideDetails.java
Outdated
Show resolved
Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/ui/ClientDetailsPanel.java
Outdated
Show resolved
Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/ui/ClientNodeDetailsPanel.java
Outdated
Show resolved
Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/ExtensionClientIntegration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
client/refactor
branch
from
f7a20a8 to
e1aa7c9
Compare
|
Fixed those :) |
thc202
approved these changes
Dec 12, 2024
|
Thank you! |
kingthorin
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move some client classes into sub-packages, in order to control the visibility of some of the methods.
Related Issues
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.