Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech detection & retire: Remove usage of CWE-200 and update other CWE #6001

Merged
merged 1 commit into from
Dec 13, 2024
Merged

tech detection & retire: Remove usage of CWE-200 and update other CWE #6001

merged 1 commit into from
Dec 13, 2024
+5 −6

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Dec 9, 2024 •
edited
Loading

Overview

  • CHANGELOGs > Add note.
  • Rules > Changed or dropped CWE.
  • Unit Tests > Updated for the new or removed CWEs.

Related Issues

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@psiinon

This comment has been minimized.

Sign in to view
@thc202 thc202 changed the title tech detection & retire: Replace usage of CWE-200 tech detection & retire: Replace usage of CWE-200 and update other CWE Dec 13, 2024
@thc202
Copy link
Member

thc202 commented Dec 13, 2024

This has conflicts.

@kingthorin kingthorin force-pushed the wapp-ret-cwe branch 2 times, most recently from c52b43e to e9740e1 Compare December 13, 2024 16:52
@kingthorin
Copy link
Member Author

Tweaked

@thc202
Copy link
Member

thc202 commented Dec 13, 2024

Thank you!

@thc202
Copy link
Member

thc202 commented Dec 13, 2024

Commit message needs tweak though (it has conflict report and to match the change in the tech detect).

@thc202 thc202 changed the title tech detection & retire: Replace usage of CWE-200 and update other CWE tech detection & retire: Remove usage of CWE-200 and update other CWE Dec 13, 2024
@kingthorin
tech detection & retire: Replace usage of CWE-200
dbeea20 
- CHANGELOGs > Add note.
- Rules > Changed or dropped CWE.
- Unit Tests > Updated for the new or removed CWEs.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Done

@ricekot ricekot merged commit 6c60578 into zaproxy:main Dec 13, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
@kingthorin kingthorin deleted the wapp-ret-cwe branch December 13, 2024 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricekot ricekot ricekot approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tech Detected scan rule - CWE-200 Vulnerable JS Library (Powered by Retire.js) - CWE-829
4 participants
@kingthorin @psiinon @thc202 @ricekot