Client: Change spider to access unvisited URLs #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Dec 6, 2024
addOns/client/src/main/java/org/zaproxy/addon/client/ExtensionClientIntegration.java
Outdated
Show resolved
Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpider.java
Show resolved
Hide resolved
psiinon
force-pushed
the
client/spider-unvisited
branch
from
5d16968 to
7279804
Compare
kingthorin
approved these changes
Dec 6, 2024
|
Interesting - the unit tests pass in Eclipse. |
|
New Issues
|
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
client/spider-unvisited
branch
from
7279804 to
0188cfe
Compare
|
Tests fixed |
kingthorin
approved these changes
Dec 6, 2024
thc202
approved these changes
Dec 10, 2024
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In ZAP with the client add-on installed open the browser and point at a running version of bodgeit.
Then run the client spider against bodgeit - it will not find anything.
This is because its listenning for "new node" events, but no new nodes are added because they were already there, just unvisited.
This PR fixes that by adding those nodes to the task list.
No changelog entry as this is still unpublished functionality 😁
Checklist
./gradlew spotlessApplyfor code formatting