Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Browser Based Authentication to Client Spider #5995

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add Browser Based Authentication to Client Spider #5995

merged 1 commit into from
Dec 13, 2024

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Dec 6, 2024 •
edited
Loading

authhelper:

  • Optionally depend on the Client Integration add-on.
    • Updated CHANGELOG and build file.
    • Add Client Integration extension & unit tests.

client:

  • Add infrastructure for handling Browser Based Authentication when available.
    • Update add-on to allow setting/tracking Authentication Handlers.
    • Client Spider Dialog, updated with Context and User fields to support the authentication choices of the user.

@psiinon

This comment was marked as resolved.

Sign in to view
@kingthorin kingthorin force-pushed the authhelper-client branch 4 times, most recently from 3de695d to 33eaac7 Compare December 11, 2024 14:47
@kingthorin kingthorin changed the title authhelper: Optionally depend on client integration authhelper/client: Optionally depend on client integration & do Browser Auth Dec 11, 2024
@psiinon
Copy link
Member

psiinon commented Dec 11, 2024

Has conflicts

@kingthorin kingthorin force-pushed the authhelper-client branch 2 times, most recently from d5c7fd4 to 314ce5a Compare December 11, 2024 18:51
@kingthorin
Copy link
Member Author

Fixed the issue you had discovered and fixed the conflicts.

@thc202 thc202 changed the title authhelper/client: Optionally depend on client integration & do Browser Auth Add Browser Based Authentication to Client Spider Dec 12, 2024
thc202
thc202 reviewed Dec 12, 2024
View reviewed changes
addOns/authhelper/CHANGELOG.md Outdated Show resolved Hide resolved
.../authhelper/src/main/java/org/zaproxy/addon/authhelper/client/ExtensionAuthhelperClient.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/AuthenticationHandler.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/AuthenticationHandler.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpider.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpiderDialog.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpiderDialog.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpiderDialog.java Outdated Show resolved Hide resolved
addOns/client/src/test/java/org/zaproxy/addon/client/ExtensionClientIntegrationUnitTest.java Outdated Show resolved Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/ExtensionClientIntegration.java Outdated Show resolved Hide resolved
@thc202
Copy link
Member

thc202 commented Dec 12, 2024

The changelog of the client add-on needs to be updated.

@kingthorin kingthorin force-pushed the authhelper-client branch 7 times, most recently from 867d345 to d47f60f Compare December 12, 2024 12:08
@kingthorin
Copy link
Member Author

Ok, hopefully got all that.

thc202
thc202 reviewed Dec 12, 2024
View reviewed changes
addOns/client/CHANGELOG.md Outdated Show resolved Hide resolved
@kingthorin
Copy link
Member Author

Done

@kingthorin
Add Browser Based Authentication to Client Spider
274d56b 
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@thc202 thc202 merged commit b27f7da into zaproxy:main Dec 13, 2024
10 checks passed
@thc202
Copy link
Member

thc202 commented Dec 13, 2024

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
@kingthorin kingthorin deleted the authhelper-client branch December 13, 2024 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@psiinon psiinon psiinon approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingthorin @psiinon @thc202