Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation: Preserve Rule ID zero #5989

Merged
merged 1 commit into from
Dec 6, 2024
Merged

automation: Preserve Rule ID zero #5989

merged 1 commit into from
Dec 6, 2024

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Dec 4, 2024 •
edited
Loading

Overview

  • Set Jackson to always include the Rule ID.
  • CHANGELOG add fix note.
  • UnitTest to ensure rule ID is serialized as expected.

Related Issues

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin kingthorin force-pushed the automation-id0 branch 2 times, most recently from db7fab7 to a577c91 Compare December 4, 2024 18:43
@psiinon

This comment was marked as resolved.

Sign in to view
@kingthorin kingthorin force-pushed the automation-id0 branch 4 times, most recently from 8e86f15 to b01afad Compare December 5, 2024 11:34
@kingthorin
Copy link
Member Author

Fixed

Dipen-Saka
Dipen-Saka reviewed Dec 6, 2024
View reviewed changes
Copy link

@Dipen-Saka Dipen-Saka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

@kingthorin
Copy link
Member Author

Tweaked unit test name

@thc202
Copy link
Member

thc202 commented Dec 6, 2024

Should the Included be Include? It was before.

@kingthorin
automation: Preserve Rule ID zero
cb0e66d 
- Set Jackson to always include the Rule ID.
- CHANGELOG add fix note.
- UnitTest to ensure rule ID is serialized as expected.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Done

@thc202
Copy link
Member

thc202 commented Dec 6, 2024

Thank you!

@kingthorin kingthorin requested a review from psiinon December 6, 2024 11:02
@psiinon psiinon merged commit 18eba19 into zaproxy:main Dec 6, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
@kingthorin kingthorin deleted the automation-id0 branch December 6, 2024 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dipen-Saka Dipen-Saka Dipen-Saka left review comments

@thc202 thc202 thc202 approved these changes

@psiinon psiinon psiinon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing active scan rule ID 0 in Automation Framework plan
4 participants
@kingthorin @psiinon @thc202 @Dipen-Saka