Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation: exitStatus job #5984

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Automation: exitStatus job #5984

merged 1 commit into from
Dec 6, 2024

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented Dec 4, 2024 •
edited by thc202
Loading

Fixes zaproxy/zaproxy#6928.

Overview

Adds a new job for setting the exit status based on various criteris.

Related Issues

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

@psiinon
Copy link
Member Author

psiinon commented Dec 4, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – ca1de07f-d08e-4063-b837-76da3f2fd60f

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-21538 Npm-cross-spawn-7.0.3 Vulnerable Package
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 27 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 46 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /cla.yml: 19 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /ci.yml: 26 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 34 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 50
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 35

@psiinon
Copy link
Member Author

psiinon commented Dec 4, 2024

Tests fixed

@thc202
Copy link
Member

thc202 commented Dec 6, 2024

Thank you!

@psiinon
Copy link
Member Author

psiinon commented Dec 6, 2024

Updated the help and changelog.

@psiinon
Copy link
Member Author

psiinon commented Dec 6, 2024

Will tweak the help again based on feedback..

@psiinon
Copy link
Member Author

psiinon commented Dec 6, 2024

Updated.

kingthorin
kingthorin approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@psiinon
Automation: exitStatus job
2f84296 
Fixes zaproxy/zaproxy#6928

Signed-off-by: Simon Bennetts <psiinon@gmail.com>
@thc202 thc202 enabled auto-merge December 6, 2024 14:34
@thc202 thc202 merged commit 87d70a5 into zaproxy:main Dec 6, 2024
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingthorin kingthorin kingthorin approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to override the exit code from the Automation Framework plan
3 participants
@psiinon @thc202 @kingthorin