Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascanrules: clean up sqli comments #5921

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

FiveOFive
Copy link
Contributor

Overview

Cleaning up sql injection scan rule code ahead of making updates for false positives in zaproxy/zaproxy#8652 This change has no logic changes. It only removes old commented out code and cleans up a few other excessive comments such as commenting the end of loops. The goal is to improve readability of the code

Related Issues

Specify any related issues or pull requests by linking to them.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Signed-off-by: FiveOFive <FiveOFive@users.noreply.github.com>
@thc202
Copy link
Member

thc202 commented Nov 16, 2024

There are some more comments that fall under the description that were not removed but less noise.

@thc202 thc202 merged commit 8cac506 into zaproxy:main Nov 16, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
@thc202
Copy link
Member

thc202 commented Nov 16, 2024

Thank you!

Ideally this should have been done as a commit in #5868. Now that one will have conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants