scripts: Allow modifying console font #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Nov 5, 2023
addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/ScriptConsoleOptionsPanel.java
Show resolved
Hide resolved
addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/ScriptConsoleOptionsPanel.java
Show resolved
Hide resolved
addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/ScriptConsoleOptionsPanel.java
Show resolved
Hide resolved
|
|
||
| <h3>Font Name</h3> | ||
| <p>Set the name of the font used in the script console. | ||
| The default font is <code>Monospaced</code>. |
There was a problem hiding this comment.
Is this a default (base install) font across Windows and MacOS as well?
There was a problem hiding this comment.
Yup. From https://docs.oracle.com/javase/tutorial/2d/text/fonts.html#logical-fonts,
These fonts are available on any Java platform and can be thought of as aliases for some underlying font that has the properties implied by its name.
There was a problem hiding this comment.
Oh okay. I had looked at some other docs for Windows but if it's an alias name then that makes more sense.
There was a problem hiding this comment.
Tweaked this for clarity.
thc202
reviewed
Nov 7, 2023
addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/ScriptConsoleOptions.java
Outdated
Show resolved
Hide resolved
addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/ScriptConsoleOptions.java
Outdated
Show resolved
Hide resolved
addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/ScriptConsoleOptionsPanel.java
Show resolved
Hide resolved
Signed-off-by: ricekot <github@ricekot.com>
|
Addressed review comments. |
thc202
approved these changes
Nov 8, 2023
|
Thank you! |
kingthorin
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provide options to allow editing the font name and size used in the Script Console code editor.
Related Issues
Checklist
./gradlew spotlessApplyfor code formatting