changes to compile at 5.0

contracts/lib/ERC20.sol

@@ -1,8 +1,8 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 contract ERC20Basic {
     uint256 public totalSupply;
-    function balanceOf(address who) public constant returns (uint256);
+    function balanceOf(address who) public pure returns (uint256);
     function transfer(address to, uint256 value) public returns (bool);
     event Transfer(address indexed from, address indexed to, uint256 value);
 }
@@ -11,7 +11,7 @@ contract ERC20 is ERC20Basic {
     string public name;
     string public symbol;
     uint256 public decimals;
-    function allowance(address owner, address spender) public constant returns (uint256);
+    function allowance(address owner, address spender) public pure returns (uint256);
     function transferFrom(address from, address to, uint256 value) public returns (bool);
     function approve(address spender, uint256 value) public returns (bool);
     event Approval(address indexed owner, address indexed spender, uint256 value);

contracts/lib/lifecycle/Destructible.sol

@@ -1,9 +1,14 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 import "../ownership/Ownable.sol";
 
+
+//was not compiling with selfdestruct(owner) added a require and changed parameter from owner to msg.sender
+
+
 contract Destructible is Ownable {
     function selfDestruct() public onlyOwner {
-        selfdestruct(owner);
+        require(owner == msg.sender);
+        selfdestruct(msg.sender);
     }
 }

contracts/lib/ownership/Ownable.sol

@@ -1,4 +1,4 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 contract Ownable {
     address public owner;

contracts/lib/ownership/Upgradable.sol

@@ -1,4 +1,4 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 import "./ZapCoordinatorInterface.sol";
 

contracts/lib/ownership/ZapCoordinator.sol

@@ -1,4 +1,4 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 import "./Upgradable.sol";
 import "./ZapCoordinatorInterface.sol";
@@ -17,7 +17,7 @@ contract ZapCoordinator is ZapCoordinatorInterface {
     DatabaseInterface public db;
 
     // used for adding contracts like Database and ZapToken
-    function addImmutableContract(string contractName, address newAddress) external onlyOwner {
+    function addImmutableContract(string calldata contractName, address newAddress) external onlyOwner {
         assert(contracts[contractName] == address(0));
         contracts[contractName] = newAddress;
 
@@ -27,7 +27,7 @@ contract ZapCoordinator is ZapCoordinatorInterface {
     }
 
     // used for modifying an existing contract or adding a new contract to the system
-    function updateContract(string contractName, address newAddress) external onlyOwner {
+    function updateContract(string calldata contractName, address newAddress) external onlyOwner {
         address prev = contracts[contractName];
         if (prev == address(0) ) {
             // First time adding this contract
@@ -43,11 +43,11 @@ contract ZapCoordinator is ZapCoordinatorInterface {
         contracts[contractName] = newAddress;
     }
 
-    function getContractName(uint index) public view returns (string) {
+    function getContractName(uint index) public view returns (string memory) {
         return loadedContracts[index];
     }
 
-    function getContract(string contractName) public view returns (address) {
+    function getContract(string memory contractName) public view returns (address) {
         return contracts[contractName];
     }
 

contracts/lib/ownership/ZapCoordinatorInterface.sol

@@ -1,11 +1,11 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 import "./Ownable.sol";
 
 contract ZapCoordinatorInterface is Ownable {
-    function addImmutableContract(string contractName, address newAddress) external;
-    function updateContract(string contractName, address newAddress) external;
-    function getContractName(uint index) public view returns (string);
-    function getContract(string contractName) public view returns (address);
+    function addImmutableContract(string calldata contractName, address newAddress) external;
+    function updateContract(string calldata contractName, address newAddress) external;
+    function getContractName(uint index) public view returns (string memory);
+    function getContract(string memory contractName) public view returns (address);
     function updateAllDependencies() external;
 }

contracts/lib/platform/Client.sol

@@ -1,25 +1,25 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 contract Client1 {
     /// @dev callback that provider will call after Dispatch.query() call
     /// @param id request id
     /// @param response1 first provider-specified param
-    function callback(uint256 id, string response1) external;
+    function callback(uint256 id, string calldata response1) external;
 }
 contract Client2 {
     /// @dev callback that provider will call after Dispatch.query() call
     /// @param id request id
     /// @param response1 first provider-specified param
     /// @param response2 second provider-specified param
-    function callback(uint256 id, string response1, string response2) external;
+    function callback(uint256 id, string calldata response1, string calldata response2) external;
 }
 contract Client3 {
     /// @dev callback that provider will call after Dispatch.query() call
     /// @param id request id
     /// @param response1 first provider-specified param
     /// @param response2 second provider-specified param
     /// @param response3 third provider-specified param
-    function callback(uint256 id, string response1, string response2, string response3) external;
+    function callback(uint256 id, string calldata response1, string calldata response2, string calldata response3) external;
 }
 contract Client4 {
     /// @dev callback that provider will call after Dispatch.query() call
@@ -28,19 +28,19 @@ contract Client4 {
     /// @param response2 second provider-specified param
     /// @param response3 third provider-specified param
     /// @param response4 fourth provider-specified param
-    function callback(uint256 id, string response1, string response2, string response3, string response4) external;
+    function callback(uint256 id, string calldata response1, string calldata response2, string calldata response3, string calldata response4) external;
 }
 
 contract ClientBytes32Array {
     /// @dev callback that provider will call after Dispatch.query() call
     /// @param id request id
     /// @param response bytes32 array
-    function callback(uint256 id, bytes32[] response) external;
+    function callback(uint256 id, bytes32[] calldata response) external;
 }
 
 contract ClientIntArray{
     /// @dev callback that provider will call after Dispatch.query() call
     /// @param id request id
     /// @param response int array
-    function callback(uint256 id, int[] response) external;
+    function callback(uint256 id, int[] calldata response) external;
 }

contracts/lib/platform/ERCDotFactory.sol

@@ -1,4 +1,4 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 import "../token/TokenFactoryInterface.sol";
 import "../token/FactoryTokenInterface.sol";
@@ -18,7 +18,7 @@ contract ERCDotFactory is Ownable {
 
     event DotTokenCreated(address tokenAddress);
 
-    constructor(address coordinator, address factory){
+    constructor(address coordinator, address factory) public {
         coord = ZapCoordinatorInterface(coordinator);
         reserveToken = FactoryTokenInterface(coord.getContract("ZAP_TOKEN"));
         reserveToken.approve(coord.getContract("BONDAGE"), ~uint256(0));
@@ -30,9 +30,9 @@ contract ERCDotFactory is Ownable {
         bytes32 providerTitle,
         bytes32 specifier,
         bytes32 symbol,
-        int256[] curve
-    ) returns(address) {
-        require(curves[specifier] == 0, "Curve specifier already exists");
+        int256[] memory curve
+    ) public returns(address) {
+        require(curves[specifier] == address(0) , "Curve specifier already exists");
 
         RegistryInterface registry = RegistryInterface(coord.getContract("REGISTRY"));
         if (!registry.isProviderInitiated(address(this))) {
@@ -42,7 +42,7 @@ contract ERCDotFactory is Ownable {
         registry.initiateProviderCurve(specifier, curve, address(this));
         curves[specifier] = newToken(bytes32ToString(specifier), bytes32ToString(symbol));
 
-        DotTokenCreated(curves[specifier]);
+        emit DotTokenCreated(curves[specifier]);
         return curves[specifier];
     }
 
@@ -62,8 +62,8 @@ contract ERCDotFactory is Ownable {
     }
 
     function newToken(
-        string name,
-        string symbol
+        string memory name,
+        string memory symbol
     )
         public
         returns (address tokenAddress)
@@ -74,7 +74,7 @@ contract ERCDotFactory is Ownable {
     }
 
     //https://ethereum.stackexchange.com/questions/2519/how-to-convert-a-bytes32-to-string
-    function bytes32ToString(bytes32 x) constant returns (string) {
+    function bytes32ToString(bytes32 x) pure public returns (string memory) {
         bytes memory bytesString = new bytes(32);
 
         bytesString = abi.encodePacked(x);

contracts/lib/platform/EthAdapter.sol

@@ -1,4 +1,4 @@
-pragma solidity ^0.4.24;
+pragma solidity ^0.5.0;
 
 import "../../platform/bondage/currentCost/CurrentCostInterface.sol";
 import "./ERCDotFactory.sol";
@@ -13,7 +13,7 @@ contract EthAdapter is ERCDotFactory {
 
     event MsgSender(address _sender);
 
-    constructor(address coordinator, address tokenFactory, uint256 rate)
+    constructor(address coordinator, address tokenFactory, uint256 rate) public 
     ERCDotFactory(coordinator, tokenFactory) {
         adapterRate = rate;
     }
@@ -23,12 +23,12 @@ contract EthAdapter is ERCDotFactory {
         adapterRate = rate;
     }
 
-    function ownerBond(address wallet, bytes32 specifier, uint numDots) payable onlyOwner {
+    function ownerBond(address wallet, bytes32 specifier, uint numDots) public payable onlyOwner {
         emit MsgSender(msg.sender);
         bond(wallet, specifier, numDots);
     }
 
-    function ownerUnbond(address wallet, bytes32 specifier, uint quantity) onlyOwner {
+    function ownerUnbond(address wallet, bytes32 specifier, uint quantity) public onlyOwner {
         unbond(wallet, specifier, quantity);
     }
 
@@ -52,8 +52,8 @@ contract EthAdapter is ERCDotFactory {
     }
 
     //Override
-    function unbond(address wallet, bytes32 specifier, uint quantity) internal {
-
+    function unbond1(address payable wallet, bytes32 specifier, uint quantity) internal {
+       
         bondage = BondageInterface(coord.getContract("BONDAGE"));
         uint issued = bondage.getDotsIssued(address(this), specifier);
 
@@ -66,10 +66,10 @@ contract EthAdapter is ERCDotFactory {
         //burn dot backed token
         tok.burnFrom(wallet, quantity);
         //send wallet eth
-        wallet.transfer(reserveCost * adapterRate);
+        address(wallet).transfer(reserveCost * adapterRate);
     }
 
-    function getAdapterPrice(bytes32 specifier, uint quantity) view returns(uint){
+    function getAdapterPrice(bytes32 specifier, uint quantity) public payable returns(uint){
         bondage = BondageInterface(coord.getContract("BONDAGE"));
         uint reserveAmount = bondage.calcZapForDots(address(this), specifier, quantity);
         return reserveAmount * adapterRate;