Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZAP_GITHUB_PREFIX variable does'nt work #141

Closed
mamaraddio opened this issue May 4, 2023 · 0 comments · Fixed by #142
Closed

ZAP_GITHUB_PREFIX variable does'nt work #141

mamaraddio opened this issue May 4, 2023 · 0 comments · Fixed by #142
Assignees

Comments

@mamaraddio
Copy link
Member

Describe the bug

When using

export ZAP_GITHUB_PREFIX="git@"

this break the ability of Zap to clone any repo due to a different syntax, let's say:

  • ssh -> git@github.com:zap-zsh/zap.git
  • https -> https://github.com/zap-zsh/zap.git

Steps to reproduce

  1. Add export ZAP_GITHUB_PREFIX="git@" to your zshrc file
  2. Now try to install a new plugin as usual with plug "repo/plugin"

This results in a "Failed to clone" message

Expected behavior

It should clone and source the new plugin, instead it returns a "Failed to clone" message

Screenshots and recordings

No response

OS / Linux distribution

N/A

Zsh version

N/A

Zap version

N/A

Terminal emulator

N/A

If using WSL on Windows, which version of WSL

None

Additional context

No response

@mamaraddio mamaraddio self-assigned this May 4, 2023
wintermi added a commit that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant