feat: no-top-level-arrow-function only report when the function bod…

…y is `BlockStatement`
zanminkian · Jan 22, 2025 · ae6cb40 · ae6cb40
1 parent 0c3b8f0
commit ae6cb40
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/spicy-snakes-mate.md b/.changeset/spicy-snakes-mate.md
@@ -0,0 +1,5 @@
+---
+"@fenge/eslint-plugin": minor
+---
+
+feat: `no-top-level-arrow-function` only report when the function body is `BlockStatement`
diff --git a/packages/eslint-plugin/src/rules/no-top-level-arrow-function.ts b/packages/eslint-plugin/src/rules/no-top-level-arrow-function.ts
@@ -1,5 +1,5 @@
 import type { Rule } from "eslint";
-import type { Node } from "estree";
+import type { ArrowFunctionExpression } from "estree";
 import { getRuleName } from "../utils.ts";
 
 const name = getRuleName(import.meta.url);
@@ -15,9 +15,10 @@ const rule: Rule.RuleModule = {
     },
   },
   create: (context) => {
-    const handle = (node: Node) => {
-      if (node.loc?.start.line === node.loc?.end.line) return;
-      context.report({ node, messageId: `${name}/error` });
+    const handle = (node: ArrowFunctionExpression) => {
+      if (node.body.type === "BlockStatement") {
+        context.report({ node, messageId: `${name}/error` });
+      }
     };
     return {
       "VariableDeclaration[parent.type='Program'] > VariableDeclarator > ArrowFunctionExpression":