Skip to content

Commit

Permalink
Update gh issue number in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
zanmato1984 committed Aug 8, 2024
1 parent 2da4b07 commit 8047780
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions cpp/src/arrow/acero/hash_join_node_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3277,8 +3277,8 @@ void AssertRowCountEq(Declaration source, int64_t expected) {

} // namespace

// Test that both the key and the payload of the right side (the build side) are fixed
// length and larger than 4GB, and the 64-bit offset in the hash table can handle it
// GH-43495: Test that both the key and the payload of the right side (the build side) are
// fixed length and larger than 4GB, and the 64-bit offset in the hash table can handle it
// correctly.
TEST(HashJoin, LARGE_MEMORY_TEST(BuildSideOver4GBFixedLength)) {
constexpr int64_t k5GB = 5ll * 1024 * 1024 * 1024;
Expand Down Expand Up @@ -3362,8 +3362,8 @@ TEST(HashJoin, LARGE_MEMORY_TEST(BuildSideOver4GBFixedLength)) {
num_batches_left * num_rows_per_batch_left * num_batches_right);
}

// Test that both the key and the payload of the right side (the build side) are var
// length and larger than 4GB, and the 64-bit offset in the hash table can handle it
// GH-43495: Test that both the key and the payload of the right side (the build side) are
// var length and larger than 4GB, and the 64-bit offset in the hash table can handle it
// correctly.
TEST(HashJoin, LARGE_MEMORY_TEST(BuildSideOver4GBVarLength)) {
constexpr int64_t k5GB = 5ll * 1024 * 1024 * 1024;
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/compute/row/compare_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsOver2GB)) {
AssertCompareColumnsToRowsAllMatch(columns_left, row_table_right, row_ids_to_compare);
}

// GH-XXXXX: Compare fixed length columns to rows over 4GB within a row table.
// GH-43495: Compare fixed length columns to rows over 4GB within a row table.
TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsOver4GBFixedLength)) {
if constexpr (sizeof(void*) == 4) {
GTEST_SKIP() << "Test only works on 64-bit platforms";
Expand Down Expand Up @@ -400,7 +400,7 @@ TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsOver4GBFixedLength)) {
AssertCompareColumnsToRowsAllMatch(columns_left, row_table_right, row_ids_to_compare);
}

// GH-XXXXX: Compare var length columns to rows at offset over 4GB within a row table.
// GH-43495: Compare var length columns to rows at offset over 4GB within a row table.
TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsOver4GBVarLength)) {
if constexpr (sizeof(void*) == 4) {
GTEST_SKIP() << "Test only works on 64-bit platforms";
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/compute/row/row_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ TEST(RowTableMemoryConsumption, Encode) {
}
}

// GH-XXXXX: Ensure that we can build a row table with more than 4GB row data.
// GH-43495: Ensure that we can build a row table with more than 4GB row data.
TEST(RowTableLarge, LARGE_MEMORY_TEST(Encode)) {
if constexpr (sizeof(void*) == 4) {
GTEST_SKIP() << "Test only works on 64-bit platforms";
Expand Down Expand Up @@ -183,7 +183,7 @@ TEST(RowTableLarge, LARGE_MEMORY_TEST(Encode)) {
row_table.offsets()[num_rows - 1] + length_per_binary);
}

// GH-XXXXX: Ensure that we can build a row table with more than 4GB row data.
// GH-43495: Ensure that we can build a row table with more than 4GB row data.
TEST(RowTableLarge, LARGE_MEMORY_TEST(AppendFrom)) {
if constexpr (sizeof(void*) == 4) {
GTEST_SKIP() << "Test only works on 64-bit platforms";
Expand Down

0 comments on commit 8047780

Please sign in to comment.