Fix lint

zanmato1984 · Oct 14, 2024 · 66d977a · 66d977a
1 parent 154ad95
commit 66d977a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/cpp/src/arrow/compute/api_vector.h b/cpp/src/arrow/compute/api_vector.h
@@ -261,7 +261,7 @@ class ARROW_EXPORT ListFlattenOptions : public FunctionOptions {
 class ARROW_EXPORT ReverseIndicesOptions : public FunctionOptions {
  public:
   explicit ReverseIndicesOptions(int64_t output_length = -1,
-                                 std::shared_ptr<DataType> output_type = nullptr);
+                                 std::shared_ptr<DataType> output_type = NULLPTR);
   static constexpr char const kTypeName[] = "ReverseIndicesOptions";
   static ReverseIndicesOptions Defaults() { return ReverseIndicesOptions(); }
 
@@ -272,7 +272,7 @@ class ARROW_EXPORT ReverseIndicesOptions : public FunctionOptions {
   /// \brief The type of the output reverse indices. If null, the output will be of the
   /// same type as the input indices, otherwise must be integer types. An invalid error
   /// will be reported if this type is not able to store the length of the input indices.
-  std::shared_ptr<DataType> output_type = nullptr;
+  std::shared_ptr<DataType> output_type = NULLPTR;
 };
 
 /// \brief Options for permute function
@@ -755,6 +755,7 @@ Result<std::shared_ptr<Array>> PairwiseDiff(const Array& array,
 ///
 /// \since 19.0.0
 /// \note API not yet finalized
+ARROW_EXPORT
 Result<Datum> ReverseIndices(
     const Datum& indices,
     const ReverseIndicesOptions& options = ReverseIndicesOptions::Defaults(),
@@ -781,6 +782,7 @@ Result<Datum> ReverseIndices(
 ///
 /// \since 19.0.0
 /// \note API not yet finalized
+ARROW_EXPORT
 Result<Datum> Permute(const Datum& values, const Datum& indices,
                       const PermuteOptions& options = PermuteOptions::Defaults(),
                       ExecContext* ctx = NULLPTR);

diff --git a/cpp/src/arrow/compute/function_test.cc b/cpp/src/arrow/compute/function_test.cc
@@ -136,6 +136,10 @@ TEST(FunctionOptions, Equality) {
   options.emplace_back(new SelectKOptions(5, {{SortKey("key", SortOrder::Ascending)}}));
   options.emplace_back(new Utf8NormalizeOptions());
   options.emplace_back(new Utf8NormalizeOptions(Utf8NormalizeOptions::NFD));
+  options.emplace_back(
+      new ReverseIndicesOptions(/*output_length=*/42, /*output_type=*/int32()));
+  options.emplace_back(new PermuteOptions());
+  options.emplace_back(new PermuteOptions(/*output_length=*/42));
 
   for (size_t i = 0; i < options.size(); i++) {
     const size_t prev_i = i == 0 ? options.size() - 1 : i - 1;