Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if any dependencies are VCS dependencies #89

Closed
Fuyukai opened this issue Nov 22, 2023 · 2 comments · Fixed by #90
Closed

Fails if any dependencies are VCS dependencies #89

Fuyukai opened this issue Nov 22, 2023 · 2 comments · Fixed by #90
Labels
bug Something isn't working

Comments

@Fuyukai
Copy link

Fuyukai commented Nov 22, 2023

Example pyproject:

$ cat pyproject.toml
[tool.poetry]
name = "test"
version = "0.1.0"
description = ""
authors = [""]
readme = "README.rst"
packages = [{include = "test", from = "src"}]

[tool.poetry.dependencies]
python = "^3.11"
httpx = {git = "https://github.com/encode/httpx.git"}


[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

Tool output:

$ poetry relax
Checking dependencies in group 'main' for relaxable constraints...

Could not parse version constraint:
@zanieb
Copy link
Owner

zanieb commented Nov 22, 2023

Thanks for the issue! The next step is to reproduce this in the test suite and get a full traceback. Presumably we can just skip any complex version specifications but maybe there are some cases where a mapping is used that we should support.

@zanieb zanieb added the bug Something isn't working label Nov 22, 2023
zanieb added a commit that referenced this issue Nov 23, 2023
zanieb added a commit that referenced this issue Nov 23, 2023
* Add failing test case for #89

* Avoid updating the constraint when it is empty

* Improve error message when constraint updates fail
@Fuyukai
Copy link
Author

Fuyukai commented Nov 23, 2023

Thanks for getting this fixed so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants