Skip to content

Commit

Permalink
staging: wfx: drop useless check
Browse files Browse the repository at this point in the history
Currently, the ISR check if bus->core is not NULL. But, it is a useless
check. bus->core is initialiased before to request IRQ and it is not
assigned to NULL when it is released.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200505123757.39506-5-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jerome-pouiller authored and gregkh committed May 13, 2020
1 parent 832cc98 commit ba52edd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
9 changes: 1 addition & 8 deletions drivers/staging/wfx/bus_sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,20 +91,13 @@ static void wfx_sdio_irq_handler(struct sdio_func *func)
{
struct wfx_sdio_priv *bus = sdio_get_drvdata(func);

if (bus->core)
wfx_bh_request_rx(bus->core);
else
WARN(!bus->core, "race condition in driver init/deinit");
wfx_bh_request_rx(bus->core);
}

static irqreturn_t wfx_sdio_irq_handler_ext(int irq, void *priv)
{
struct wfx_sdio_priv *bus = priv;

if (!bus->core) {
WARN(!bus->core, "race condition in driver init/deinit");
return IRQ_NONE;
}
sdio_claim_host(bus->func);
wfx_bh_request_rx(bus->core);
sdio_release_host(bus->func);
Expand Down
4 changes: 0 additions & 4 deletions drivers/staging/wfx/bus_spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ static irqreturn_t wfx_spi_irq_handler(int irq, void *priv)
{
struct wfx_spi_priv *bus = priv;

if (!bus->core) {
WARN(!bus->core, "race condition in driver init/deinit");
return IRQ_NONE;
}
queue_work(system_highpri_wq, &bus->request_rx);
return IRQ_HANDLED;
}
Expand Down

0 comments on commit ba52edd

Please sign in to comment.