if "latest" for revision, grab latest deployment available for proxy #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. This looks like a step in the direction of fixing issue #8 too. Does that make sense? |
|
Yep that is exactly what this does. If the revision is 'latest' terraform will grab the most recent deployed revision for some api proxy and use that as the target revision for the deployment resource. It's also nice if you dont want to depend on the |
|
I took a look at the issue you opened hashicorp/terraform#15857 and this is exactly what we were running into. This is a bit hacky, but gets the job done. |
|
Nice! Thanks for the contribution. |
|
@zambien great, mind giving it an approval then ill push out a new release? |
zambien
approved these changes
Mar 15, 2019
|
you got it! |
|
hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a change that allows for users to set
revision="latest"in their.tffiles. During the Update stage, terraform will fetch the latest valid revision from the api proxy and deploy that revision.