chore(ci): add should-run to tfhe-fft and tfhe-ntt tests #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Feb 20, 2025
.github/workflows/cargo_test_fft.yml
Outdated
Comment on lines
116
to
122
| - name: All tests success | ||
| if: needs.should-run.outputs.fft_test == 'true' && | ||
| needs.cargo-tests-fft.result == 'success' && | ||
| needs.cargo-tests-fft-nightly.result == 'success' && | ||
| needs.cargo-tests-fft-node-js.result == 'success' | ||
| run: | | ||
| echo "All tfhe-fft test passed" |
There was a problem hiding this comment.
is this enough to fail the build if one of the tests fails ?
There was a problem hiding this comment.
The push I just made should fix this. Thanks for noticing.
This is done to avoid testing tfhe-ftt/ntt crates if nothing changes in their source files. However, these tests would be run unconditionally on each push on main branch.
soonum
force-pushed
the
dt/ci/add_should_runs
branch
from
ffbfe76 to
d918a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to avoid testing tfhe-ftt/ntt crates if nothing changes in their source files.
However, these tests would be run unconditionally on each push on main branch.