Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix release workflow for tfhe-versionable #2090

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Feb 20, 2025

tfhe-versionable crate depends on tfhe-versionable-derive. Workflow, now ensure that derive crate is published before attempting to package tfhe-versionable.

Dry-run option is removed since it cannot be use correctly due the reason aforementioned.

tfhe-versionable crate depends on tfhe-versionable-derive.
Workflow, now ensure that derive crate is published before
attempting to package tfhe-versionable.

Dry-run option is removed since it cannot be use correctly due
the reason aforementioned.
@soonum soonum added the ci label Feb 20, 2025
@soonum soonum requested a review from IceTDrinker February 20, 2025 08:42
@soonum soonum self-assigned this Feb 20, 2025
@cla-bot cla-bot bot added the cla-signed label Feb 20, 2025
@soonum soonum requested a review from nsarlin-zama February 20, 2025 08:42
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
Sadly we cannot test this before next release :\

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good indeed !

@soonum soonum merged commit 5d9af12 into main Feb 20, 2025
225 checks passed
@soonum soonum deleted the dt/ci/release_tfhe_versionable branch February 20, 2025 10:45
@soonum
Copy link
Contributor Author

soonum commented Feb 20, 2025

closes: zama-ai/tfhe-rs-internal#921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants