Tm/hlapi strings in list #2072
Merged
Tm/hlapi strings in list #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this introducing this trait is to purposefully create a breaking change so that later we have more freedom on refactoring some stuff with less risk of breaking
tmontaigu
force-pushed
the
tm/hlapi-strings-in-list
branch
from
c424898 to
f657a00
Compare
IceTDrinker
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tmontaigu)
tfhe/src/high_level_api/compact_list.rs line 402 at r1 (raw file):
} pub trait HlCompactable: Compactable {}
should be sealed or not in the end ?
IceTDrinker
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tmontaigu)
tmontaigu
force-pushed
the
tm/hlapi-strings-in-list
branch
from
43f1b05 to
c967303
Compare
IceTDrinker
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tmontaigu)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is