Tm/backports #2058
Merged
Tm/backports #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Signed and Unsigned DataKind, the degree was incorrectly set, leading to unneeded carry propagations
Some counts where to copied from the correct source to correct destination. And more importantly, the list on cuda side was stored using a GlweCiphertextList but the data was compressed (so the list was mostly empty). This use of a GlweList instead of a specialized type lead to problems when converting to Cpu
This commit fixes a few bugs
* The shift/rotate functions used when blocks encrypt a number of bits
that is a power of 2 was causing a panic when working on one block.
- Also, when the number of blocks was low (e.g 2 blocks with 2_2
params) a noise cleaning step was wrongly skipped
* The function used when blocks encrypt non power of 2 number of bits
also had a problem
The test have been updated to test with different block sizes and check
the noise level
Overall these bugs only affected low block counts (e.g FheUint2,
FheUint4) ciphertexts
- the CPU data layout is truncated to only store relevant bodies (i.e. emtpy bodies are assumed to be 0) but the GPU CUDA code manages full GLWEs only. To fix that we manage the data layout during conversions to have consistent behavior when copying the list to/from CPU/GPU. Compression code has been fixed on the CPU side to have the proper length for the output expected by the CUDA code
IceTDrinker
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of a few bug fixes