chore(ci): remove pull_request_target for external contributions #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soonum
force-pushed
the
dt/ci/remove_pr_target
branch
6 times, most recently
from
de9b7af to
d48c114
Compare
soonum
changed the title
IceTDrinker
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Reviewed 5 of 31 files at r1, all commit messages.
Reviewable status: 5 of 31 files reviewed, 1 unresolved discussion (waiting on @soonum)
.github/actions/gpu_setup/action.yml line 48 at r1 (raw file):
echo "CUDA_PATH=$CUDA_PATH" >> "${GITHUB_ENV}" echo "PATH=$PATH:$CUDA_PATH/bin" >> "${GITHUB_PATH}" echo "LD_LIBRARY_PATH=$CUDA_PATH/lib64:$LD_LIBRARY_PATH" >> "${GITHUB_ENV}"
you have whitespaces here and below at the end of the line
We use large GitHub hosted runners to run CI pipeline for external contributions. This avoids possible secret exposition due to usage of pull_request_target event. It also removes a layer a complexity to ensure such secrets are not exposed. The flow would be improved since tfhe-rs maintainers won't have to relaunch failed jobs individually, thanks to the "approve and run" button in GitHub user interface.
soonum
force-pushed
the
dt/ci/remove_pr_target
branch
from
d48c114 to
6bc87fe
Compare
IceTDrinker
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks a lot !
Reviewed 26 of 31 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IceTDrinker)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use large GitHub hosted runners to run CI pipeline for external contributions.
This avoids possible secret exposition due to usage of pull_request_target event.
It also removes a layer a complexity to ensure such secrets are not exposed.
The flow would be improved since tfhe-rs maintainers won't have to relaunch failed jobs individually, thanks to the "approve and run" button in GitHub user interface.
This change is