-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(tfhe): add dark market example #188
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @yagizsenal on file. In order for us to review and merge your code, please send an email to hello@zama.ai to get yourself added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your bounty contribution!
There is a small addition we would want to make in the tutorial.
For the code there may be a way to showcase one of TFHE-rs tree-like reduction (though you used the one from rayon) and there may be a trick to speed up the fill order routine by potentially doing more work but exploiting more threads on an m6i.metal AWS instance, the machine has 64 CPUS and 128 threads and 500 Gigs of ram
My suggestion would be to explore the proposed alternative approach (creating a dedicated function in your code) on a small use case for your dev machine (which has a lower amount of thread to see if the implementation works ok) and then we can bench that on the m6i.metal to see if we are gaining for the overall computation time.
Cheers
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @yagizsenal on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
fd2cc85
to
f51e6b5
Compare
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @yagizsenal on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
@yagizsenal have you signed the T&C for individual contributor? |
first request for this PR: squash in a single commit and follow the commit message format, in that case it should be
|
f51e6b5
to
4039770
Compare
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @yagizsenal on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
I just signed CLA and T&C. I also updated the commit message. |
ok, we should have the updated infos for the cla bot soon, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a few more detailed comments otherwise this looks very good.
We'll probably manage the location in our docs ourselves to make it easier and avoid additional back and forth on this PR.
Cheers!
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
4039770
to
08fe1ec
Compare
Thanks, updated accordingly. |
08fe1ec
to
c1f8397
Compare
2622431
to
bb002e6
Compare
This pull request solves the Dark Market bounty.
Two file change has been made and two new files are added to the repository.
tfhe/Cargo.toml
file has been updated to include the new example.tfhe/docs/SUMMARY.md
file has been changed to include links to the added Dark Market tutorial.tfhe/docs/tutorial/dark_market.md
file is added to describe how to implement the Dark Market algorithm with TFHE-rs.tfhe/examples/dark_market.rs
file is added that consists of three different implementations of the Dark Market algorithm: Plain, FHE and Parallelized FHE. These implementations can be run with the commands given in the tutorial.Thank you so much
Yagiz