Impl versionize for statically sized arrays #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/versionize_arrays
branch
from
2342eff to
b7b3884
Compare
kc1212
approved these changes
Aug 2, 2024
|
I added a test with a struct containing all these types |
nsarlin-zama
force-pushed
the
ns/versionize_arrays
branch
from
03d31d6 to
a52fc90
Compare
tmontaigu
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add versionize support for statically sized arrays (
[T; N]) andstd::num::Wrapping<T>.Static arrays are converted to slice/vec before versioning since serde does not support const generics in arrays: serde-rs/serde#1937