Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

feat: support for bin descriptors #198

Merged
merged 1 commit into from
Dec 10, 2022
Merged

feat: support for bin descriptors #198

merged 1 commit into from
Dec 10, 2022

Conversation

xander34
Copy link
Contributor

@xander34 xander34 commented Nov 5, 2022

Adding support for pre-compiled proto-bin descriptors.
If the discovery root ends with ".bin" it is considered a pre-compiled proto-bin descriptor file.

Adding support for proto bin descriptors
@codecov-commenter
Copy link

Codecov Report

Merging #198 (9eea208) into master (52a2817) will increase coverage by 0.48%.
The diff coverage is 97.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
+ Coverage     96.77%   97.26%   +0.48%     
- Complexity      180      316     +136     
============================================
  Files            17       22       +5     
  Lines           683     1132     +449     
  Branches         41       72      +31     
============================================
+ Hits            661     1101     +440     
- Misses           16       20       +4     
- Partials          6       11       +5     
Impacted Files Coverage Δ
...n/zalopay/benchmark/core/channel/DoneObserver.java 100.00% <ø> (ø)
.../benchmark/core/grpc/DynamicMessageMarshaller.java 100.00% <ø> (ø)
...lopay/benchmark/core/protobuf/ServiceResolver.java 87.50% <85.71%> (-1.79%) ⬇️
...zalopay/benchmark/core/protobuf/ProtocInvoker.java 94.77% <92.59%> (-1.86%) ⬇️
...lopay/benchmark/core/config/GrpcRequestConfig.java 96.15% <96.15%> (ø)
...n/java/vn/zalopay/benchmark/core/ClientCaller.java 96.10% <97.84%> (+1.65%) ⬆️
...main/java/vn/zalopay/benchmark/GRPCSamplerGui.java 98.64% <98.18%> (-1.36%) ⬇️
...rc/main/java/vn/zalopay/benchmark/GRPCSampler.java 100.00% <100.00%> (ø)
...alopay/benchmark/constant/GrpcSamplerConstant.java 100.00% <100.00%> (ø)
...ain/java/vn/zalopay/benchmark/core/ClientList.java 96.29% <100.00%> (+3.43%) ⬆️
... and 16 more

@anhldbk anhldbk requested a review from huynhminhtan November 7, 2022 07:19
@pmirek
Copy link

pmirek commented Nov 25, 2022

Hi, any information when this part of code is merged and available in released jar? Thanks!

@huynhminhtan huynhminhtan merged commit af88100 into zalopay-oss:master Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants