This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
fix: ClientCaller bugs #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhldbk
reviewed
Oct 24, 2022
| } | ||
| } catch (InterruptedException e) { | ||
| throw new RuntimeException("Caught exception while shutting down channel", e); | ||
| } finally { | ||
| channel = null; // 清理channel |
There was a problem hiding this comment.
Would you please comment in English?
nexttonever
force-pushed
the
fe_fix_bug
branch
from
a8e95ce to
5214361
Compare
[fix] channel closed and not reopen after any error happend, e.g., Deadline [feat] add protoc cache [fix] unwrap ExecutionException in call GrpcSamplerTest.testCanSendSampleRequestWithErrorNullResponse modify deadline to escape Deadline error ClientCallerTest.testThrowExceptionWithExceptionInProtocInvoke use a temporary config to escape protoc cache Signed-off-by: zhiyizhao <zhiyizhao@lightinthebox.com>
nexttonever
force-pushed
the
fe_fix_bug
branch
from
5214361 to
ebe027f
Compare
|
@huynhminhtan PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallerClient:
[fix] channel closed and not reopen after any error happend, e.g., Deadline
[feat] add protoc cache
[fix] unwrap ExecutionException in call
GrpcSamplerTest.testCanSendSampleRequestWithErrorNullResponse
modify deadline to escape Deadline error
ClientCallerTest.testThrowExceptionWithExceptionInProtocInvoke
use a temporary config to escape protoc cache