composeWithDevTools: Infinite recursion when used with enhanced getState

[danhart]

Here's a very basic, valid, store enhancer that essentially wraps the store's original getState in a new getState function:

const basicStoreEnhancer = (createStore) => (...args) => {
  const store = createStore(...args);

  return {
    ...store,
    getState: () => store.getState(),
  };
};

When used with Redux's compose, this enhancer works perfectly with no impact at all. However, when used within a composeWithDevTools, it results in a RangeError: Maximum call stack size exceeded.

This is because of this line, which mutates the store causing our getState call to become infinitely recursive:

redux-devtools-extension/src/browser/extension/inject/pageScript.js

Line 310 in dc39a63

stores[instanceId].getState = store.getState;

It's possible to work around the issue like this:

const basicStoreEnhancer = (createStore) => (...args) => {
  const store = createStore(...args);
  const originalGetState = store.getState;

  return {
    ...store,
    getState: () => originalGetState(),
  };
};

These issues seem relevant:
#248
#551

[zalmoxisus]

Thanks for the details and for investigation! That mutation was introduced for enhancers which change the store after our enhancer was applied (as in #133). But I tried now with saga example and it seems unnecessary now, a lot was changed since then.

[zalmoxisus]

It should work in 2.16, which will land in a day on Chrome Store. Thanks again for debugging it!