Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect and documented Zally rule introduced failures #1268

Closed
dneuhaeuser-zalando opened this issue Jun 24, 2021 · 1 comment · Fixed by #1269
Closed

Incorrect and documented Zally rule introduced failures #1268

dneuhaeuser-zalando opened this issue Jun 24, 2021 · 1 comment · Fixed by #1269

Comments

@dneuhaeuser-zalando
Copy link
Member

We have recently started getting violations reported from Zally such as:

MUST Path parameters validation
	Parameter blocklist_id: "content" property should have exactly one entry
	https://github.com/zalando/zally/blob/master/server/rules.md#z001-path-parameters-validation
		components > parameters > BlocklistId (lines 31-40)

The corresponding path parameter has a schema property. The OpenAPI spec defines schema and content to be mutually exclusive. So this is simply wrong.

The link in the error message is also wrong and doesn't provide an explanation on this anywhere on the linked page.

@vadeg
Copy link
Contributor

vadeg commented Jun 24, 2021

@dneuhaeuser-zalando could you give a schema example?

vadeg added a commit that referenced this issue Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants