Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Add x-request-host and x-request-uri headers #192

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Add x-request-host and x-request-uri headers #192

merged 1 commit into from
Oct 23, 2017

Conversation

kevinsimper
Copy link
Contributor

Add x-request-host and x-request-uri headers to allow passing down information to fragments that will not be filtered out by default.

Based on discussion in #189

@kevinsimper kevinsimper mentioned this pull request Oct 22, 2017
Closed
@addityasingh
Copy link
Contributor

👍

DeTeam
DeTeam reviewed Oct 22, 2017
View reviewed changes
tests/filter-headers.js Outdated
'user-agent': '3'
'user-agent': '3',
'x-request-uri': 'localhost',
'x-request-host': '/example'
Copy link
Contributor

@DeTeam DeTeam Oct 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinsimper guess host's and uri's values should be swapped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good spottet! 👍

@codecov
Copy link

codecov bot commented Oct 22, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@832f078). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage          ?   98.29%           
=========================================
  Files             ?       14           
  Lines             ?      588           
  Branches          ?      106           
=========================================
  Hits              ?      578           
  Misses            ?       10           
  Partials          ?        0
Impacted Files Coverage Δ
lib/filter-headers.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832f078...2029b62. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 22, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@832f078). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage          ?   98.29%           
=========================================
  Files             ?       14           
  Lines             ?      588           
  Branches          ?      106           
=========================================
  Hits              ?      578           
  Misses            ?       10           
  Partials          ?        0
Impacted Files Coverage Δ
lib/filter-headers.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832f078...2029b62. Read the comment docs.

@DeTeam
Copy link
Contributor

DeTeam commented Oct 23, 2017

👍

1 similar comment
@addityasingh
Copy link
Contributor

👍

@DeTeam DeTeam merged commit 8fc3e73 into zalando:master Oct 23, 2017
@DeTeam DeTeam mentioned this pull request Oct 23, 2017
Merged
@kevinsimper
Copy link
Contributor Author

Nice 😄🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeTeam DeTeam DeTeam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinsimper @addityasingh @DeTeam