Use @Configuration(proxyBeanMethods=false) to avoid unnecessary gener… #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSchumacher
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
|
👍 |
|
Can you sign your commits? |
…ation of cglib proxies. Signed-off-by: Pascal Schumacher <pascalschumacher@gmx.net>
PascalSchumacher
force-pushed
the
use_Configuration_proxyBeanMethods_false
branch
from
c30a5c1 to
d4b215c
Compare
I updated the commit to add |
|
No, it's this one: https://help.github.com/en/github/authenticating-to-github/signing-commits |
|
To much for work for one trival change. Sorry. |
|
👍 |
|
Fair enough. I disabled the check for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation of cglib proxies.Cglib proxy creation can be an expensive operation.
Similar to spring-projects/spring-boot#9068
I think this is a breaking change if somebody calls methods on the configuration classes.