Manage a token name only once

[mohabusama]

Manage a token name only once. This avoids resetting already valid token for the same token name.

• some styling and tests

Signed-off-by: Mohab Usama mohab.abdelhameed@zalando.de

[coveralls]

Coverage remained the same at 100.0% when pulling 4488cce on mohabusama:manage-token-once into fc6cedf on zalando-stups:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 4488cce on mohabusama:manage-token-once into fc6cedf on zalando-stups:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 4488cce on mohabusama:manage-token-once into fc6cedf on zalando-stups:master.

[mohabusama]

@hjacobs could you please take a look?

[hjacobs]

LGTM, but there is the theoretical breaking change for situations where multiple manage calls were made for the same token name: the latest config won before this PR, now the first call to manage wins. Probably just a theoretical case, but still a noteworthy change in behaviour.

[mohabusama]

Yeah, thought about it!
Was thinking about allow resetting in case the scopes changed, but that would involve locking (threading or multiprocessing?) to be more or less accurate. I felt it would get complex compared to a rather more straightforward/expected usage: "call this once for each token".

[hjacobs]

👍

[mohabusama]

👍