Make it possible to allow collaborator admin access in pet clusters #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
reviewed
Jan 20, 2020
| collaborator_administrator_access: "false" | ||
| {{else}} | ||
| collaborator_administrator_access: "true" | ||
| {{end}} |
There was a problem hiding this comment.
Is the logic not reversed here? Should be true in case of e2e?
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
aermakov-zalando
force-pushed
the
collaborator-pet-cluster
branch
from
597d78d to
635efd7
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Jan 24, 2020
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only allow access to e2e clusters, but pet clusters should also work.