Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collaborator role: fix daemonsets #2876

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Collaborator role: fix daemonsets #2876

merged 2 commits into from
Jan 20, 2020

Conversation

aermakov-zalando
Copy link
Contributor

@aermakov-zalando aermakov-zalando commented Jan 20, 2020 •
edited
Loading

  • Fix apiGroups, daemonsets don't live in core.
  • Remove the restriction on the resource name, no point in doing it.

@aermakov-zalando
Collaborator role: fix apiGroups
9efa149 
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
@aermakov-zalando
Remove resourceNames from the role
aeb3d18 
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
@aermakov-zalando aermakov-zalando changed the title Collaborator role: fix apiGroups Collaborator role: fix daemonsets Jan 20, 2020
@aermakov-zalando
Copy link
Contributor Author

👍

@szuecs
Copy link
Member

szuecs commented Jan 20, 2020

This would allow everyone to deploy daemonsets, not?

@aermakov-zalando
Copy link
Contributor Author

No, only those with the collaborator roles.

@szuecs
Copy link
Member

szuecs commented Jan 20, 2020 •
edited
Loading

👍

@aermakov-zalando aermakov-zalando merged commit e98f4c8 into dev Jan 20, 2020
@aermakov-zalando aermakov-zalando deleted the fix-visibility-rbac branch January 20, 2020 09:37
This was referenced Jan 20, 2020
Merged
Merged
This was referenced Jan 24, 2020
Closed
Closed
Closed
@zalando-teapot-robot zalando-teapot-robot mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged/alpha merged/beta merged/stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aermakov-zalando @szuecs @zalando-teapot-robot