Bind Emergency and Manual Groups same as PowerUser #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
force-pushed
the
manual-emergency-rbac
branch
from
f4e764d
to
015400f
Compare
|
👍 |
aryszka
reviewed
Jul 29, 2019
| } | ||
| }`, | ||
| expect: expect{ | ||
| status: http.StatusCreated, |
There was a problem hiding this comment.
just curious: why are we using 201, when the request was rejected?
There was a problem hiding this comment.
This is how the AccessReview API works. You "create" a review request 201 and then the response is whether the user would have access to perform that action or not.
|
👍 |
Merged
mikkeloscar
added a commit
that referenced
this pull request
Jul 30, 2019
Partly revert of #2358 to allow only `cdp` service account to `escalate` Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Merged
aermakov-zalando
pushed a commit
that referenced
this pull request
Aug 1, 2019
Partly revert of #2358 to allow only `cdp` service account to `escalate` Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
aermakov-zalando
added a commit
that referenced
this pull request
Aug 1, 2019
Cherry-pick #2358 to alpha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binds
EmergencyandManualGroups same way asPowerUsersince they are defined to have the same permissions.This is currently done in the auth webhook, but we should migrate to RBAC to fix blacklist/whitelist bugs in the auth webhook.