Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Tests for last-seen state calculation and comparison #91

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Jun 1, 2019

Issue : #13

Add tests for last-seen state (calculation and comparison).

The last seen state is used to detect the causes when something was changed (and what specifically), or to detect of the object is completely new (no previous seen state).

Partially, this is tested in the causation tests (indirectly). But there, it tests for how the states & diffs are used, without testing the details on the field level, and not all functions are fully tested.

The diff calculation (between old & new states) is left aside, as there are separate tests for it in /tests/diffs/.

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Jun 1, 2019
@nolar nolar added this to the 1.0 milestone Jun 1, 2019
@nolar nolar requested a review from samurang87 as a code owner June 1, 2019 13:17
@zincr
Copy link

zincr bot commented Jun 1, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

  • ℹ️ kopf/test_lastseen.py had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
     

@zincr
Copy link

zincr bot commented Jun 1, 2019

🤖 zincr found 1 problem , 1 warning

❌ Approvals
ℹ️ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

  • ℹ️ kopf/test_lastseen.py had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
     

@nolar nolar mentioned this pull request Jun 1, 2019
19 tasks
@nolar nolar merged commit 5308ed9 into zalando-incubator:master Jun 13, 2019
@nolar nolar deleted the test-lastseen branch June 13, 2019 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants