This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the finalizers: appending, removing, checking.
Also change the finalizer to a FQDN string — as once I hit the issue that the finalizer cannot be an arbitrary string (e.g. when assigning it to a pod in Minikube; but it works with custom resources though).
But keep the legacy finalizer (just a string, not FQDN) if it is assigned to the existing resource — for checking and for removing.