Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Test for finalizers #90

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Jun 1, 2019

Issue : #13

Add tests for the finalizers: appending, removing, checking.

Also change the finalizer to a FQDN string — as once I hit the issue that the finalizer cannot be an arbitrary string (e.g. when assigning it to a pod in Minikube; but it works with custom resources though).

But keep the legacy finalizer (just a string, not FQDN) if it is assigned to the existing resource — for checking and for removing.

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Jun 1, 2019
@nolar nolar added this to the 1.0 milestone Jun 1, 2019
@nolar nolar requested a review from samurang87 as a code owner June 1, 2019 13:13
@zincr
Copy link

zincr bot commented Jun 1, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Jun 1, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar mentioned this pull request Jun 1, 2019
19 tasks
@nolar nolar merged commit 4c614d3 into zalando-incubator:master Jun 7, 2019
@nolar nolar deleted the test-finalizers branch June 7, 2019 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants