Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Test the CLI invocation, including logging in & preloading #39

Merged
merged 4 commits into from
Apr 30, 2019
Merged

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Apr 22, 2019

Issue : #13

It is straightforward: no explanations needed. Just the tests and few non-critical fixes detected during the tests.

@nolar nolar requested a review from samurang87 as a code owner April 22, 2019 11:40
@zincr
Copy link

zincr bot commented Apr 22, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

  • ℹ️ tests/cli/test_login.py had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
     

@nolar nolar mentioned this pull request Apr 22, 2019
19 tasks
@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Apr 26, 2019
samurang87
samurang87 previously approved these changes Apr 30, 2019
@nolar nolar added this to the 1.0 milestone Apr 30, 2019
samurang87
samurang87 previously approved these changes Apr 30, 2019
@nolar
Copy link
Contributor Author

nolar commented Apr 30, 2019

@samurang87 And the last time please, with all the merge conflicts with the new features resolved (and just rebased on master) ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants