Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Speed up e2e tests and make them exiting gracefully #216

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Oct 28, 2019

Issue : #13 #59

Description

Improve e2e tests to wait for the stop-words in the logs instead of just waiting for the time. It was quite common that the e2e tests do not fit into the empirically guessed timings, so the timings had to be increased far above what was normally needed — thus slowing the e2e tests.

This became even more important for the tests that contain the artificial delays, such as sleep, temporary errors with delays, or arbitrary exceptions with the default retry delay (even if mocked).

Now, they default delay is 10 seconds, but the tests continue as soon as they see the specially defined stop-words for each stage (creation, deletion; later: startup, cleanup).

In addition, the KopfRunner was improved to stop the background operator gracefully instead of the forced cancellation (which had no graceful period).

Types of Changes

  • Refactor/improvements

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Oct 28, 2019
@nolar nolar requested a review from samurang87 as a code owner October 28, 2019 17:19
@nolar nolar requested a review from thilp October 28, 2019 17:19
@zincr
Copy link

zincr bot commented Oct 28, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Oct 28, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

thilp
thilp previously approved these changes Oct 28, 2019
@nolar nolar merged commit ba5f145 into zalando-incubator:master Nov 6, 2019
@nolar nolar deleted the e2e-stop-flag branch November 6, 2019 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants