Add tag to button component #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c1c90e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84dd3f93.react-science.pages.dev |
| Branch Preview URL: | https://649-add-count-to-toolbar-ite.react-science.pages.dev |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 22.24% 22.17% -0.07%
==========================================
Files 220 220
Lines 13081 13166 +85
Branches 236 236
==========================================
+ Hits 2910 2920 +10
- Misses 10081 10156 +75
Partials 90 90 ☔ View full report in Codecov by Sentry. |
stropitek
reviewed
Feb 12, 2024
There was a problem hiding this comment.
- Allow
tagPropsto be passed to toolbar component as well. If thestyleprop is passed totagProps, it should probably not override things like "absolute" which are in the defaultstyle. - In button and toolbar stories, do not show example with tag in control. Show tag in specific story.
- Stories with longer tags than 1 chars. Up to 3 chars for the toolbar story to see how it looks like in that case.
stropitek
approved these changes
Feb 19, 2024
|
@wadjih-bencheikh18 There is a conflict left to resolve |
|
@stropitek conflict resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #649