fix: make Modal's onRequestClose mandatory and call it on close #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING-CHANGE: Modal's and ConfirmModal's `onRequestClose` is now mandatory. Note that a Modal has to always be closed (`isOpen` must be set to `false`) when `onRequestClose` is called. This is driven by a change in the HTML spec that ensures a web page cannot indefinitely keep a dialog open. See whatwg/html#9462 and https://bugs.chromium.org/p/chromium/issues/detail?id=1511166#c1
Deploying with
|
| Latest commit: |
db25587
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f4c9652.react-science.pages.dev |
| Branch Preview URL: | https://fix-modal.react-science.pages.dev |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 24.49% 24.50%
=======================================
Files 223 223
Lines 12954 12954
Branches 234 234
=======================================
+ Hits 3173 3174 +1
+ Misses 9693 9692 -1
Partials 88 88 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING-CHANGE: Modal's and ConfirmModal's
onRequestCloseis now mandatory.Note that a Modal has to always be closed (
isOpenmust be set tofalse) whenonRequestCloseis called.This is driven by a change in the HTML spec that ensures a web page cannot indefinitely keep a dialog open.
See whatwg/html#9462 and https://bugs.chromium.org/p/chromium/issues/detail?id=1511166#c1