Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Portal for context menu #444

Merged
merged 2 commits into from
Jan 18, 2023
Merged

fix: use Portal for context menu #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06ce564
fix: use Portal for context menu
hamed-musallam Jan 18, 2023
ba8b178
stories: add table with context menu in the header
hamed-musallam Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions src/components/dropdown-menu/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,24 +72,26 @@ function DropdownContextMenu<T>(props: Omit<DropdownMenuProps<T>, 'trigger'>) {
return (
<HandleMenuContextDiv onContextMenu={handleContextMenu}>
{isPopperElementOpen && (
<div ref={ref}>
<div
ref={setPopperElement}
style={styles.popper}
{...attributes.popper}
>
<Menu>
<MenuItems
itemsStatic
onSelect={(selected) => {
closePopperElement();
onSelect(selected);
}}
{...otherProps}
/>
</Menu>
<Portal>
<div ref={ref}>
<div
ref={setPopperElement}
style={styles.popper}
{...attributes.popper}
>
<Menu>
<MenuItems
itemsStatic
onSelect={(selected) => {
closePopperElement();
onSelect(selected);
}}
{...otherProps}
/>
</Menu>
</div>
</div>
</div>
</Portal>
)}

{children}
Expand Down
83 changes: 82 additions & 1 deletion stories/components/dropdown.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@ import {
MenuItems,
MenuOptions,
} from '../../src/components/dropdown-menu/MenuItems';
import { DropdownMenu } from '../../src/components/index';
import {
DropdownMenu,
Table,
ValueRenderers,
} from '../../src/components/index';
import data from '../data/table.json';

export default {
title: 'Components / DropdownMenu',
Expand Down Expand Up @@ -187,3 +192,79 @@ export function Complex() {
</Menu>
);
}
export function TableWithHeaderDropDownMenu() {
const options = useMemo<MenuOptions<string>>(() => {
return [
{ label: 'Back', type: 'option', icon: <FaAddressBook /> },
{
label: 'Forward',
type: 'option',
disabled: true,
icon: <FaAccessibleIcon />,
},
{ label: 'Refresh', type: 'option', icon: <Fa500Px /> },
{ type: 'divider' },
{ label: 'Save as', type: 'option', icon: <FaAccusoft /> },
{ label: 'Print', type: 'option', icon: <FaAcquisitionsIncorporated /> },
{ label: 'Cast media to device', type: 'option', icon: <FaAd /> },
{ type: 'divider' },
{
label: 'Send page to your devices',
type: 'option',
icon: <FaAddressCard />,
},
{
label: 'Create QR Code for this page',
type: 'option',
icon: <FaAdjust />,
},
];
}, []);

return (
<table>
<thead>
<tr>
<ColumnWithDropdownMenu value="id" options={options} />
<ColumnWithDropdownMenu value="name" options={options} />
<ColumnWithDropdownMenu value="rn" options={options} />
<ColumnWithDropdownMenu value="mw" options={options} />
<ColumnWithDropdownMenu value="em" options={options} />
<ColumnWithDropdownMenu value="isExpensive" options={options} />
<ColumnWithDropdownMenu value="color" options={options} />
</tr>
</thead>
<tbody>
{data
.slice(0, 2)
.map(({ id, name, rn, mw, em, isExpensive, color }) => (
<Table.Row key={id}>
<ValueRenderers.Text value={id} />
<ValueRenderers.Text value={name} />
<ValueRenderers.Text value={rn} />
<ValueRenderers.Number value={mw} fixed={2} />
<ValueRenderers.Number value={em} fixed={4} />
<ValueRenderers.Boolean value={isExpensive} />
<ValueRenderers.Color value={color} />
</Table.Row>
))}
</tbody>
</table>
);
}

function ColumnWithDropdownMenu({
value,
options,
}: {
value: string;
options: MenuOptions<string>;
}) {
return (
<td>
<DropdownMenu trigger="contextMenu" onSelect={noop} options={options}>
<div>{value}</div>
</DropdownMenu>
</td>
);
}