Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dialog to add a AboutUs Modal #400

Merged
merged 4 commits into from
Nov 23, 2022
Merged

feat: add dialog to add a AboutUs Modal #400

merged 4 commits into from
Nov 23, 2022

Conversation

Sebastien-Ahkrin
Copy link
Contributor

close: #376

Capture d’écran 2022-11-21 à 15 57 43

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b3ad528
Status: ✅  Deploy successful!
Preview URL: https://2ba09b62.analysis-ui-components.pages.dev
Branch Preview URL: https://feat-aboutdialog.analysis-ui-components.pages.dev

View logs

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an example about dialog to the demo app
You can put it instead of the useless logo:
image

src/app/about/AboutDialogToolbarButton.tsx Outdated Show resolved Hide resolved
src/app/about/AboutDialogToolbarButton.tsx Outdated Show resolved Hide resolved
src/pages/big-map/MainLayout.tsx Outdated Show resolved Hide resolved
@targos targos merged commit 352ebab into main Nov 23, 2022
@targos targos deleted the feat-aboutdialog branch November 23, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AboutDialogToolbarButton component
2 participants