Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use a template for the loaders #354

Merged
merged 16 commits into from
Nov 15, 2022
Merged

refactor: use a template for the loaders #354

merged 16 commits into from
Nov 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 14, 2022

  • The loaders have now a more similar structure
  • Added a few corrections to the default technique in biologic
  • Added a logger?:boolean key to loaders and load function (maybe this needs to be further up?)
  • Rolled back some wrong ideas for the types (Measurements -> Partial<Measurements>)

For example, this is how it shows the error for biologic:
Screenshot from 2022-11-14 14-12-33

PR is related to issue #291 but I am not sure whether this is enough @lpatiny.

Question

As a user it would be simpler if the measurement explorer labels are in the same side than the axis:

image

So the ylabel on the left, the right for x as a default maybe? Would this be preferred?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 75f98b8
Status: ✅  Deploy successful!
Preview URL: https://e1185bee.analysis-ui-components.pages.dev
Branch Preview URL: https://harmonise-parsers.analysis-ui-components.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Base: 88.01% // Head: 83.01% // Decreases project coverage by -5.00% ⚠️

Coverage data is based on head (75f98b8) compared to base (d3c41f8).
Patch coverage: 72.13% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   88.01%   83.01%   -5.01%     
==========================================
  Files          12       14       +2     
  Lines         868     1042     +174     
  Branches      133      144      +11     
==========================================
+ Hits          764      865     +101     
- Misses        104      177      +73     
Impacted Files Coverage Δ
...-data/loaders/proprietary/agilent/cary500Loader.ts 82.02% <48.27%> (-17.98%) ⬇️
src/app-data/loaders/biologicLoader.ts 70.12% <56.92%> (-3.76%) ⬇️
src/app-data/loaders/wdfLoader.ts 86.40% <62.50%> (-11.60%) ⬇️
src/app-data/loaders/cdfLoader.ts 84.37% <73.01%> (-7.25%) ⬇️
src/app-data/loaders/jcampLoader.ts 74.76% <73.68%> (-11.45%) ⬇️
src/app-data/DataState.ts 93.20% <100.00%> (+0.13%) ⬆️
src/app-data/loadMeasurements.ts 100.00% <100.00%> (ø)
...data/loaders/utility/getMeasurementInfoFromFile.ts 100.00% <100.00%> (ø)
src/app-data/loaders/utility/parserLog.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Nov 14, 2022

Added a logger?:boolean key to loaders and load function (maybe this needs to be further up?)

Yes, please move to the options of https://github.com/zakodium-oss/analysis-ui-components/blob/f2c23f8952f036e230e2a02706ade65bd60c1cdc/src/app-data/loadMeasurements.ts#L11

@targos
Copy link
Member

targos commented Nov 15, 2022

@santimirandarp Do you think you can finish this PR today? Otherwise I'll take it over because I need it.

@ghost
Copy link
Author

ghost commented Nov 15, 2022

I added what I could @targos, if that's the wrong idea it is fine to close it for me, I was trying to log the errors to improve the parser mostly ha

@targos targos merged commit 02adad5 into main Nov 15, 2022
@targos targos deleted the harmonise-parsers branch November 15, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants