Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cdf loader for gcms added #290

Merged
merged 9 commits into from
Oct 30, 2022
Merged

feat: cdf loader for gcms added #290

merged 9 commits into from
Oct 30, 2022

Conversation

josoriom
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Oct 29, 2022

Deploy Preview for analysis-ui-components ready!

Name Link
🔨 Latest commit 91f01ec
🔍 Latest deploy log https://app.netlify.com/sites/analysis-ui-components/deploys/635e172dd5d1e70009713221
😎 Deploy Preview https://deploy-preview-290--analysis-ui-components.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Base: 91.73% // Head: 92.45% // Increases project coverage by +0.71% 🎉

Coverage data is based on head (91f01ec) compared to base (43adbe8).
Patch coverage: 97.02% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   91.73%   92.45%   +0.71%     
==========================================
  Files           9       10       +1     
  Lines         593      689      +96     
  Branches      100      111      +11     
==========================================
+ Hits          544      637      +93     
- Misses         49       52       +3     
Impacted Files Coverage Δ
src/app/data/loaders/cdfLoader.ts 96.87% <96.87%> (ø)
src/app/data/loaders/biologicLoader.ts 85.29% <100.00%> (ø)
src/app/data/loaders/jcampLoader.ts 83.33% <100.00%> (ø)
.../data/loaders/proprietary/agilent/cary500Loader.ts 97.18% <100.00%> (ø)
src/app/data/loaders/wdfLoader.ts 97.97% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This experiment should appear like one measurement. This means that in the tab on the top right there should be only one line

image

What we expect after the parsing in this case is to have many 'dataincdex'

image

One entry by time.

Currently the component that displays the data is a 'debug component' that allows to inspect everything that is in the measurement but after we will have specific component for a specific measurement. So in this case a specific GC / MS or LC / MS component.

@lpatiny
Copy link
Contributor

lpatiny commented Oct 29, 2022

You can not test it directly in the preview

2022-10-29 07 33 55

Or test it locally using npm run app-dev. You can either drag and drop the agilent netcdf file or also click on the top link.

@lpatiny
Copy link
Contributor

lpatiny commented Oct 30, 2022

I still had to do many changes

  1. If it is an array let's try to name systematically the variable in plural (masses, intensities)
  2. If we have an array or array like in this case I named them allMasses, allIntensities
  3. I removed the bpc because it is a derived data. We have a way to have a 'postProcessor' and we will do

@lpatiny lpatiny merged commit 79f9147 into zakodium-oss:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants