-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load ium state #267
feat: load ium state #267
Conversation
✅ Deploy Preview for analysis-ui-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 92.40% // Head: 91.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 92.40% 91.67% -0.74%
==========================================
Files 10 10
Lines 685 757 +72
Branches 111 122 +11
==========================================
+ Hits 633 694 +61
- Misses 52 63 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is ok for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loading an .ium
file should be a separate path than loading other types of files, and it's not a "loader".
You should check if the file collection contains a unique nmrium file. If yes replace the current app state with the new state. If not use the loaders to add measurements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after my last comment is resolved
closes #216